Bug 6155: blShowSorting used for frontend user sorting #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in the frontend
|
Hi Preethi, thanks for your work, but there are several tests failing. Can you have a look at them? Thank you! |
|
@sebbbbauer I have made the necessary changes to the Pull request's Unit test file. Kindly check if clears all the required tests. |
roman-1983
reviewed
Mar 22, 2017
robertblank
pushed a commit
that referenced
this pull request
Apr 4, 2017
Disabling blShowSorting not considered in details locator with category default sorting When the option blShowSorting is disabled and a default sorting is set to a category the details locator of the products has no ongoing article positions. - blShowSorting is set in the backend only to allow/deny sorting by user in the frontend Conflicts: source/Application/Component/Locator.php - Modified the unit test file for the corresponding pull request Conflicts: tests/Unit/Application/Controller/LocatorTest.php Closes #431
Sieg
pushed a commit
that referenced
this pull request
Jul 21, 2017
Disabling blShowSorting not considered in details locator with category default sorting When the option blShowSorting is disabled and a default sorting is set to a category the details locator of the products has no ongoing article positions. - blShowSorting is set in the backend only to allow/deny sorting by user in the frontend Conflicts: source/Application/Component/Locator.php - Modified the unit test file for the corresponding pull request Conflicts: tests/Unit/Application/Controller/LocatorTest.php Closes #431
Sieg
pushed a commit
that referenced
this pull request
Aug 30, 2017
Disabling blShowSorting not considered in details locator with category default sorting When the option blShowSorting is disabled and a default sorting is set to a category the details locator of the products has no ongoing article positions. - blShowSorting is set in the backend only to allow/deny sorting by user in the frontend Conflicts: source/Application/Component/Locator.php - Modified the unit test file for the corresponding pull request Conflicts: tests/Unit/Application/Controller/LocatorTest.php Closes #431
Sieg
added a commit
that referenced
this pull request
Aug 30, 2017
|
Thanks, the pr was merged to master recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blShowSorting is set in the backend only to allow/deny sorting by user in the frontend